Feature #4881

Add Settings support to stock VX-8R.

Added by Keith Williamson 6 months ago. Updated 6 months ago.

Status:Resolved Start date:06/05/2017
Priority:Normal Due date:
Assignee:Keith Williamson % Done:

100%

Category:-
Target version:0.4.1
Chirp Version:0.4.0 Model affected:(All models)

Description

Current VX8 driver only supports settings for VX-8DR and VX-8GE. This effort adds settings support for stock VX-8R.

Associated revisions

Revision 2903:e7ce98c23586
Added by Keith Williamson 6 months ago

[vx8] Simple refactor that moves most VXDRadio class functions to VXRadio parent class. Fixes #4881
This is the first of two groundwork patches for adding Settings support for the VX-8R. This patch
produces no change in functionality.

Revision 2904:6710bdb49f30
Added by Keith Williamson 6 months ago

[vx8] Mod to radio memory layout to accommodate diffs between models. Fixes #4881
Split the memobj aprs struct into three structs: shorter aprs struct, aprs_msg_macro
struct and aprs2 struct. The aprs_msg_macro[] struct and aprs2 struct are parameterized
differently in the VX8Radio class and VX8DRadio class _mem_params. Updated all
dereferences of memory elements formerly part of the aprs struct that are now part
of either the aprs2 struct or the aprs_msg_macro[] struct. There are no behavioral
changes to Chirp with this patch.

Revision 2905:4963f1f6cc3c
Added by Keith Williamson 6 months ago

[vx8] Fix line longer than 79 chars and add missing pad value to seekto format string. Fix #4881

Revision 2906:fa2ef4dedc56
Added by Keith Williamson 6 months ago

[vx8] Added Settings support for stock VX-8R radio. Fixes #4881
This patch adds settings support by adding has_settings True in the
get_features function, by copying the original _get_aprs_tx_settings function
back down to the VX8DRadio class, and by creating a truncated version of that
function in the parent VX8Radio class that just gets the settings that
are defined for the VX-8R. Also, a _get_settings function for the VX8Radio
class was created that calls a subset of functions of the _get_settings
function in the VX8DRadio class. The get_features function in the VX8DRadio
class has been removed since the one in the VX8Radio class is now the same.

History

Updated by Keith Williamson 6 months ago

  • % Done changed from 0 to 50

Created patch vx8-4881-1 which lays out initial groundwork by moving all functions that will be needed for settings support from the VXDRadio class up to the VX8Radio class. This patch doesn't change any current behavior.

Updated by Keith Williamson 6 months ago

  • % Done changed from 50 to 80

Created patch vx8-4881-2 which modifies the memobj aprs struct to accommodate the memory layout differences between the VX-8DR/VX-8GE and VX-8R. This patch provides the remainder of the groundwork necessary to add settings support for the stock VX-8R. This patch doesn't change any current behavior. The next (and hopefully final) patch will provide the actual setting support for the VX-8R.

Updated by Keith Williamson 6 months ago

Resubmitted patch "vx8-4881-2.patch" as "vx8-4881-3.patch" because of PEP-8 error due to a line that was greater than 79 characters.

Updated by Keith Williamson 6 months ago

Submitted new patch "vx8-4881-4.patch" against tip since patch "vx8-4881-3.patch" was rejected. Patch "vx8-4881-3.patch" was to be a replacement for patch
"vx8-4881-2.patch" that corrected a PEP-8 line > 79 chars error. However, "vx8-4881-2.patch" was integrated with the error so instead we needed just a new patch against the tip to fix the PEP-8 error. This little patch also corrects a #seekto statement that I had added without the correct padding value (was 0x%0X..corrected to 0x%04X).

Updated by Keith Williamson 6 months ago

  • % Done changed from 80 to 100

Submitted patch "vx8-4881-5.patch" which adds settings to the VX-8R. All tests
against the VX-8R, VX-8DR, and VX-8GE images files pass including the settings test for the VX-8R.

Updated by Keith Williamson 6 months ago

  • Status changed from New to Resolved

Resolved with final patch of series (vx-4881-5.patch).

Also available in: Atom PDF