Bug #543

VX-8 flags.valid is never set (introduced revision 1496)

Added by Sean Burford over 4 years ago. Updated over 4 years ago.

Status:Closed Start date:02/11/2013
Priority:Normal Due date:
Assignee:Sean Burford % Done:

100%

Category:-
Target version:0.3.1 Estimated time:0.50 hour
Chirp Version:0.3.0 Platform:All
Model affected:vx-8dr

Description

Hi,

Chirp daily and release 0.3.0 do not save or apply new channel memories because the valid flag for the memory is never set to True. Existing channel memories can be modified, but attempts to populate empty channel memories do not succeed. The UI shows the new settings, however uploading them to the radio or saving/loading them does not result in the change being applied.

The reason for this is that revision 1496 changed flags handling in vx8.py from setting opaque u8 values to manipulating named bit fields. Here is the diff:
http://chirp.danplanet.com/projects/chirp/repository/diff/chirp/vx8.py?rev=36ece7b1a4af&rev_to=d1aa69eb5fe9
The lines where flag.valid used to be set are:
- 256 flag.flag = 0x83 # Masked from VFO B
+ 270 flag.nosubvfo = True # Masked from VFO B
And:
- 258 flag.flag = 0x03 # Available in both VFOs
+ 272 flag.nosubvfo = False # Available in both VFOs

As shown above, set_memory() in vx8.py used to (blindly) set the used (0x02) and valid (0x01) flags. Now it sets used (elsewhere in set_memory()) but never sets valid.

I don't know the difference between used and valid, however I expect that modifying line 263 to set flag.valid = flag.used would fix this.

vx8-valid.patch (299 Bytes) Sean Burford, 02/11/2013 01:30 pm


Related issues

duplicated by Bug #575: Not save frequencies Rejected 02/16/2013

Associated revisions

Revision 1898:83d7f967c0c2
Added by Sean Burford over 4 years ago

[vx8] Enable memory slots when they are first populated #543

Revision 1963:b2836ace1bf1
Added by Sean Burford over 4 years ago

[vx8] Enable memory slots when they are first populated #543

History

Updated by Sean Burford over 4 years ago

I have confirmed that setting flag.valid = flag.used results in new channel memories showing on the radio and also in saved/loaded image files.

Updated by Tom Hayward over 4 years ago

Please email your patch for this fix to the chirp_devel mailing list. More info at Developers. Welcome aboard!

Updated by Sean Burford over 4 years ago

Mailed the patch to chirp_devel (in moderation?). Attached here for completeness.

Updated by Stu Gee over 4 years ago

Yes, this exact issue happens for me. Introduced in 0.3.0

Updated by Tom Hayward over 4 years ago

  • Status changed from New to Resolved
  • Assignee set to Sean Burford
  • % Done changed from 0 to 100

Updated by Tom Hayward over 4 years ago

  • Status changed from Resolved to Needs Backport
  • Target version set to 0.3.1

Stu Gee wrote:

Introduced in 0.3.0

and fixed in r1898.

Updated by Dan Smith over 4 years ago

  • Status changed from Needs Backport to Closed

Also available in: Atom PDF