Feature #159

Get pylint happy with chirp

Added by Dan Smith over 5 years ago. Updated over 2 years ago.

Status:In Progress Start date:05/02/2012
Priority:Normal Due date:
Assignee:Zach Welch % Done:

0%

Category:-
Target version:0.5.0
Chirp Version:daily Model affected:(All models)

Associated revisions

Revision 1598:451967768d01
Added by Filippi Marco over 5 years ago

[FT817-857] reduce pylint to silence
In support of #159

Revision 1594:7b7138623cd5
Added by Dan Smith over 5 years ago

A first round of fixes to make pylint happy

These are confined to the chirp/ module, excluding bitwise.

#159

Revision 1597:f3bfdfcfd1bc
Added by Dan Smith over 5 years ago

Fix a bug introduced in the first pylint patch
Related to #159

Revision 1603:5c02cb1f49e9
Added by Dan Smith over 5 years ago

Fix remaining pylint errors in the chirp module
Related to #159

Revision 1658:d3f6a4f8fd33
Added by Ed Santiago over 5 years ago

_wouxun_identify(): wrong variable name in retry handling
Fallout from #159

Revision 2259:f878a12ef24c
Added by Filippi Marco about 3 years ago

[FT8x7] code cleanup

No functional changes at all, only some code cleanup to make code look better
and pylint happier

In support of #159

Revision 2258:eb367b01c7bc
Added by Filippi Marco about 3 years ago

[ic9x] code cleanup

No functional changes at all, only some code cleanup to make code look better
and pylint happier

In support of #159

Revision 2260:db313703132b
Added by Filippi Marco about 3 years ago

[common] code cleanup

No functional changes at all: blanks removed

In support of #159

Revision 2310:ded7178ad0e0
Added by Filippi Marco almost 3 years ago

[FT1D] code cleanup

No functional changes at all, only some code cleanup to make code look better
and pylint happier

In support of #159

Revision 2371:f34e7a029af3
Added by Filippi Marco almost 3 years ago

[ft857] Fix coding style

No functional changes at all, this patch exists only to pass style checks

relates to #159

History

Updated by Dan Smith over 5 years ago

  • % Done changed from 0 to 20

Updated by Dan Smith almost 5 years ago

  • Target version changed from 0.3.0 to 0.3.1
  • Chirp Version changed from 0.2.2 to 0.2.3

Updated by Dan Smith over 4 years ago

  • Target version deleted (0.3.1)
  • Chirp Version changed from 0.2.3 to 0.3.0

Updated by Zach Welch over 2 years ago

  • Tracker changed from Bug to Feature
  • Status changed from New to In Progress
  • Assignee changed from Dan Smith to Zach Welch
  • Target version set to 0.5.0
  • % Done changed from 20 to 0
  • Chirp Version changed from 0.3.0 to daily

I have a couple of patches in the works to add pylint to the cpep8 script (see #2355). This allows the source code to be automatically scanned as part of run_all_tests.sh. It includes a new blacklist to exclude files that are not yet compliant.

Unfortunately, not a single file was pylint compliant when I started looking at this task. I was able to get a couple of files fixed up without too much pain, but most of the modules have brutally long lists of issues (far beyond what was flagged/fixed by pep8).

On the bright side, pylint is clearly superior to pep8 in terms of completeness. For example, it already helped me find a latent error in the new logger module. I think that we will be better off with this kind of checking in place.

That said, there are points of contention between the pep8 tool and pylint, so I have disabled a couple of checks that pep8 already says we pass (e.g. line continuation alignment, multiple spaces after commas). There are likely additional checks that need to be disabled.

Also available in: Atom PDF