Project

General

Profile

Actions

Bug #10263

closed

chirpc fails to set tone options

Added by Stuart Longland almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Start date:
01/13/2023
Due date:
% Done:

100%

Estimated time:
Chirp Version:
next (py3)
Model affected:
Not applicable -- driver doesn't get a look in here
Platform:
Linux
Debug Log:
I read the instructions above:

Description

When configuring a memory channel via chirpc, the chirpc tries to access properties that no longer exist.

RC=0 stuartl@rikishi ~/hamradio/repeaters $ python3 /home/stuartl/projects/chirp/chirpc --mmap /tmp/test.img '--set-mem-name=WICEN Smplx 23cm' --set-mem-freq=1294800 --set-mem-tencon --set-mem-tenc=91.5 --set-mem-dup= --set-mem-offset=20000 --set-mem-mode=FM 0
Traceback (most recent call last):
File "/home/stuartl/projects/chirp/chirpc", line 347, in
mem.tencEnabled = True
File "/home/stuartl/projects/chirp/chirp/chirp_common.py", line 344, in setattr
raise ValueError("No such attribute %s'" % name)
ValueError: No such attribute
tencEnabled'

The following change worked for me…
https://github.com/sjlongland/chirp/commit/9946030aa795ffa135d5249798afa1b1bed8044f

… however, I only used tone-encode. I haven't tested tone squelch or DTCS as the former is rarely needed and no repeaters near me use the latter.

If the above looks good, I can submit the PR on Github to fix this.

Actions #1

Updated by Stuart Longland almost 2 years ago

Bug tracker just mangled that stack trace badly, and "Edit" won't let me edit it to fix it.

RC=0 stuartl@rikishi ~/hamradio/repeaters $ python3 /home/stuartl/projects/chirp/chirpc --mmap /tmp/test.img '--set-mem-name=WICEN Smplx 23cm' --set-mem-freq=1294800 --set-mem-tencon --set-mem-tenc=91.5 --set-mem-dup= --set-mem-offset=20000 --set-mem-mode=FM 0
Traceback (most recent call last):
  File "/home/stuartl/projects/chirp/chirpc", line 347, in <module>
    mem.tencEnabled = True
  File "/home/stuartl/projects/chirp/chirp/chirp_common.py", line 344, in __setattr__
    raise ValueError("No such attribute `%s'" % name)
ValueError: No such attribute `tencEnabled'
Actions #2

Updated by Dan Smith almost 2 years ago

  • Assignee set to Stuart Longland
  • Target version set to chirp-py3

Oh wow, yeah, super old. chirpc doesn't get a lot of love, as you can tell :)

Diff looks fine, put Fixes: #10263 in the commit message and this will be closed and linked when it is merged.

Actions #3

Updated by Stuart Longland almost 2 years ago

No problems, I've just submitted it here: https://github.com/kk7ds/chirp/pull/390

Actions #4

Updated by Stuart Longland almost 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF