Project

General

Profile

Actions
Copy link

Bug #10999

closed

Empty tx frequencies are not detected, resulting in a wrong split frequency for Baofeng radios

Added by Sander van der Wel 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
High
Assignee:
Sander van der Wel
Category:
-
Target version:
chirp-py3
Start date:
12/09/2023
Due date:
% Done:

100%

Estimated time:
1.00 h
Chirp Version:
next
Model affected:
All radios using baofeng_common.py
Platform:
Windows
Debug Log:
I read the instructions above:
Yes

Description

In baofeng_common.py in the function _is_txinh, a string is checked instead of a byte array. This results in a wrong tx frequency when it's empty.

Actions
Copy link
 #1

Updated by Jim Unroe 5 months ago

Likely the same cause as issue #10993. I can take care of it, if you wish.

Line 531...

        return raw_tx == "\xFF\xFF\xFF\xFF"

should be this...

        return raw_tx == b"\xFF\xFF\xFF\xFF"
Actions
Copy link
 #2

Updated by Sander van der Wel 5 months ago

Jim Unroe I already made a pull request. It's a small change.

Actions
Copy link
 #3

Updated by Jim Unroe 5 months ago

Sander van der Wel wrote in #note-2:

Jim Unroe I already made a pull request. It's a small change.

Thank you.

Actions
Copy link
 #4

Updated by Sander van der Wel 5 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF

Copyright 2023 CHIRP Software LLC