Bug #11344
closedCrash while deleting or writing in row 0 with BTECH_GMRS-V2, latest CHIRP
100%
Description
Chirp Crashes when attempting to access row 0. Row 0 is empty.
If I attempt to delete Row 0, chirp crashes.
If I attempt to move Row 1 up into Row 0, chirp crashes.
100% repeatable for me. Windows 11 Home, 23H2, build 22631.3527
BTECH_GMRS-V2, latest CHIRP next-20240511 on Python 3.10.8 wxPython 4.2.0 msw (phoenix) wxWidgets 3.2.0 [OK]
Files
| BTECH_GMRS-V2_cjshaker_2024-05-12.img (8.2 KB) BTECH_GMRS-V2_cjshaker_2024-05-12.img | |||
| ChirpVersion.png (7.85 KB) ChirpVersion.png | Latest Chirp next | ||
| RowZeroEmpty.png (95.1 KB) RowZeroEmpty.png | Row 0 is empty | ||
| BTECH_GMRS-V2_cjshaker_2024-05-13.img (8.2 KB) BTECH_GMRS-V2_cjshaker_2024-05-13.img | Moved block up into row 0 without crashing today | ||
| chirp_debug-2rqmr1yh.txt (1.75 KB) chirp_debug-2rqmr1yh.txt | |||
| chirp_debug-6trvzdt1.txt (17.2 KB) chirp_debug-6trvzdt1.txt |
Updated by Dan Smith 7 months ago
Okay, I was able to replicate the crash on "move up", so I got that fixed. I can't replicate the delete case. Your image has memory location zero as empty, which chirp pretty much treats as a no-op. Meaning, it doesn't do much of anything in that case. Are you talking about delete-and-shift, or single delete?
I know it might seem odd, but I need really really specific details on how to replicate this to make sure we're doing the same thing, down to which row is selected, how you're triggering the delete, etc. Something like:
- Open the sample image
- Click on the zero-row header
- Right-click in place
- Select Delete->This memory
- etc
Thanks!
Updated by Chris Shaker 7 months ago
Dan:
Wow, that was fast. Thank you!
Now, I cannot reproduce the crash while deleting row 0 either. Pretty
sure when it happened the Frequency cell in row 0 had a ring around it.
In fact, right now, I CAN move the block of programming up into row 0
without crashing. Still running the same build from May 11. Very weird
that it is working now.
Chris
On 5/13/2024 2:34 PM, Dan Smith wrote:
Updated by Chris Shaker 7 months ago
- File BTECH_GMRS-V2_cjshaker_2024-05-13.img BTECH_GMRS-V2_cjshaker_2024-05-13.img added
- File chirp_debug-2rqmr1yh.txt chirp_debug-2rqmr1yh.txt added
- File chirp_debug-6trvzdt1.txt chirp_debug-6trvzdt1.txt added
I was able to move the block of channel programming up into row 0 without crashing today. No idea why it is working now.
Attached the image file CHIRP produced today, and the two CHIRP debug logs from today in case that helps at all.
Chris
Updated by Dan Smith 7 months ago
Okay, the move bug is very clear and I know what was happening. You said the delete bug was 100%, so I figured it'd be easy to replicate but perhaps it was combined with move operations such that you were actually just tickling one bug? On my development system, I would actually sometimes trigger the move bug and it wouldn't fully die, but the next thing I did was bound to crash as a result. Perhaps something like that?
Either way, to replicate the move bug, the "ring" as you call it has to be on row 0, but be moving rows up into it. So if the frequency column of row 0 is "ringed" and you click on the row header for row 1 (i.e. trigger the row background select, but don't move the "ring") then do a move up.
Anyway, I'll mark this as fixed by the move-up fix, but if you end up being able to replicate the delete thing comment here (or open another bug if after the next build).
Updated by Chris Shaker 7 months ago
Sounds correct to me.
Thank you for fixing this so fast!
Chris Shaker, KJ7BLE
On 5/13/2024 3:15 PM, Dan Smith wrote:
Updated by Dan Smith 7 months ago
- Status changed from New to Closed
- % Done changed from 0 to 100
Applied in changeset github|ed7c02f07fa7cc71dc415e5f8de8256ccece0940.