Project

General

Profile

Actions

Bug #4689

closed

Edge tests do not match input validation edges

Added by Tom Hayward over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
03/29/2017
Due date:
% Done:

100%

Estimated time:
Chirp Version:
daily
Model affected:
(All models)
Platform:
All
Debug Log:
I read the instructions above:

Description

When entering a frequency, it is only considered valid when it is less than the high bound set in @RadioFeatures.valid_bands@:

source:chirp/chirp_common.py#L922

        if self.valid_bands:
            valid = False
            for lo, hi in self.valid_bands:
                if lo <= mem.freq < hi:
                    valid = True
                    break
            if not valid:
                msg = ValidationError(
                    ("Frequency {freq} is out "
                     "of supported range").format(freq=format_freq(mem.freq)))
                msgs.append(msg)

However, the edge test only passes if the frequency can be set equal to the high bound (which isn't possible in the UI due to above validation):

source:tests/run_tests#L536

        for limits in rf.valid_bands:
            for freq in limits:
                m.freq = freq

This raises the question: is @valid_bands@ supposed to be inclusive, as the edge test requires? If so, many drivers will need to be updated. Alternatively, fix the test to match the input validation and assumptions in the drivers.

Actions

Also available in: Atom PDF