Bug #887: upper valid_bands check is < instead of <= - CHIRP

Actions

Copy link

Bug #887

closed

upper valid_bands check is < instead of <=

Added by Charles Boling over 11 years ago. Updated over 10 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Filippi Marco

Category:

Target version:

Start date:

05/28/2013

Due date:

% Done:

Estimated time:

Chirp Version:

daily

Model affected:

IC-208

Platform:

All

Debug Log:

I read the instructions above:

Description

The check of the upper bound of valid_bands (2013-05-28 daily: chirp_common.py line 887 is inconsistent -- inclusive on the low end, exclusive on the high:

    if lo <= mem.freq < hi:

The check (at least according to the frequencies defined for the IC-208) should be inclusive at both ends, i.e.

    if lo <= mem.freq <= hi:

Actions

Copy link

Updated by Filippi Marco over 11 years ago

Status changed from New to Feedback
Assignee set to Filippi Marco
Model affected changed from (All models) to IC-208
Platform changed from Windows to All

The frequency check is asimmetric by design: in fact most radio which says to go from lo to hi does not include the upper limit.
But we can arrange the hi freq to be "one step" more to include the actual limit.
Can you please confirm the higher freq you can actually tune on radio for each of the supported band?
(I don't have this radio)

Tnx

Actions

Copy link

Updated by Charles Boling over 11 years ago

118.000-173.995 MHz
230.000-549.995 MHz
810.000-999.990 MHz

I confirm that these are the actual min/max frequencies that my radio will tune in each range, either by knob, direct entry on the radio, or by cloning.

Note: The .990 vs .995 is not a mistake. Not mentioned in the manual is the fact that in the 810-999.99 MHz band, the minimum tuning step size available from the radio is 10 kHz, instead of the 5kHz available in the other ranges. While the cloning function will allow you to override this and put in a .xx5, it doesn't change the boundary; i.e. it accepts 999.975 and 999.985, but not 999.995.

Actions

Copy link