Feature #10151
closedFeature #7431: Python3-friendly UI based on wxPython
Implement RadioReference query in the wxUI
0%
Updated by Dan Smith almost 2 years ago
- Subject changed from Implement RadioReference query to Implement RadioReference query in the wxUI
Updated by Mark Leigh almost 2 years ago
I can probably spend some time on this as I've done work on the py2 version in the not-so-distant past. Does this feature need command line functionality maintained? I recall that being an extra pain when I was working on it. The gui version would probably come quicker if we're not retaining command line functionality.
Updated by Dan Smith almost 2 years ago
I'm not aware of any CLI support for these query sources, so ... no? :) I didn't write the RR stuff initially, so perhaps the person that did went above and beyond, but it's not something I have context on .
If you want to work on that, that's cool. Any idea on when? I've got a chunk of "vacation" coming up where I was going to close some of these gaps. I'll put this at the end of my list and if you get to it first, then that's great.
Updated by Mark Leigh almost 2 years ago
Great. Thanks. It looks like someone has already been working on the radioreference import; was that you? Actually it seems that most of it is old code from py2... except that all of the code dealing with Canada has been removed? Any idea where/why? All the GUI references to the Canada import are gone too...
Updated by Mark Leigh almost 2 years ago
Now that I think about it, I suppose this py3 branch was forked before I did all that work...
Updated by Dan Smith almost 2 years ago
I haven't done anything on RR in the py3 branch. I implemented Repeaterbook import there, and made some structure in query_sources.py for the UI stuff that I think you should be able to re-use.
The py3 branch is fully sync'd with master (meaning any changes to master have been pulled into the py3 branch), but since the UI is different, the RR stuff needs to be exposed there as well.
Updated by Mark Leigh almost 2 years ago
Sorry Dan, not sure what on earth I was looking at/not looking at. Everything is there. I'll get cracking.
Cheers.
Updated by Dan Smith almost 2 years ago
- Status changed from New to In Progress
- Assignee changed from Dan Smith to Mark Leigh
No worries, thanks much and let me know if you need help!
Updated by Mark Leigh almost 2 years ago
- % Done changed from 0 to 20
Thanks. Going well so far, made quite a bit of progress tonight. Will resume tomorrow.
Updated by Mark Leigh almost 2 years ago
- % Done changed from 20 to 40
Much progress. Slow as I get my head around wx but it's coming along.
Updated by Mark Leigh almost 2 years ago
- % Done changed from 40 to 60
Canada import is done! And that's the harder of the two. Come to think of it, not sure why I started with the Canada version. I'll do tox testing etc and put it through some stress testing before I submit anything. Nothing about it is pretty, nor efficient nor the "right" way... but it does work and seems robust so far.
I pushed to my fork on github. Not ready for a PR but you can see it if you want. Not yet tox'd.
Updated by Dan Smith almost 2 years ago
- Status changed from In Progress to Closed
Marking this as closed since I believe we're at parity, modulo bugs, with the old version.