Bug #5099: Code Cleanup patch - CHIRP

Actions

Copy link

Bug #5099

closed

Code Cleanup patch

Added by Ryan J over 7 years ago. Updated almost 5 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Target version:

chirp-legacy

Start date:

08/24/2017

Due date:

% Done:

Estimated time:

Chirp Version:

daily

Model affected:

(All models)

Platform:

Windows

Debug Log:

I read the instructions above:

Description

Hey there,

I just inherited a pile of radios and started playing with CHIRP. I noticed that some of the code style is showing it's age and I went ahead and did a general cleanup. They only thing preventing this from running on Python3 is the use of unicode() in repeaterbook.py, platform.py and pyPEG.py. I decided to take a break and show the work I've done to make sure this is desired.

I am attaching a patch file here but did the work on a Github mirror of the code (https://github.com/Cabalist/chirp) I know you all use mercury and not Github but I couldn't find a way to open a pull request here. Let me know if you have any questions or even if this is wanted.

Thanks! I really appreciate that this exists. :)

Files

modernize_python.patch (203 KB) modernize_python.patch

Python2+3 changes

Ryan J, 08/24/2017 11:44 PM

Actions

Copy link

Updated by Jim Unroe over 7 years ago

Status changed from New to Feedback

This "CHIRP Development Process":http://chirp.danplanet.com/projects/chirp/wiki/DevelopersProcess page is pretty much what I have been referring to since 2012.

Jim KC9HI

Actions

Copy link

Updated by Bernhard Hailer almost 5 years ago

Hi Ryan, I hope you have subscribed to the developers email list since. If you haven't, please check the Wiki here as well: Developers.

Let us know whether you would like to keep the ticket open until your patches make it, or whether we can close it. Be aware that there are efforts underways to make things run on Python 3 already.

Actions

Copy link