Bug #5099

Code Cleanup patch

Added by Ryan J about 3 years ago. Updated 7 months ago.

Status:Closed Start date:08/24/2017
Priority:Normal Due date:
Assignee:- % Done:

0%

Category:-
Target version:chirp-daily
Chirp Version:daily Platform:Windows
Model affected:(All models)

Description

Hey there,

I just inherited a pile of radios and started playing with CHIRP. I noticed that some of the code style is showing it's age and I went ahead and did a general cleanup. They only thing preventing this from running on Python3 is the use of unicode() in repeaterbook.py, platform.py and pyPEG.py. I decided to take a break and show the work I've done to make sure this is desired.

I am attaching a patch file here but did the work on a Github mirror of the code (https://github.com/Cabalist/chirp) I know you all use mercury and not Github but I couldn't find a way to open a pull request here. Let me know if you have any questions or even if this is wanted.

Thanks! I really appreciate that this exists. :)

modernize_python.patch - Python2+3 changes (202.5 kB) Ryan J, 08/24/2017 11:44 pm

History

Updated by Jim Unroe about 3 years ago

  • Status changed from New to Feedback

This CHIRP Development Process page is pretty much what I have been referring to since 2012.

Jim KC9HI

Updated by Bernhard Hailer 8 months ago

Hi Ryan, I hope you have subscribed to the developers email list since. If you haven't, please check the Wiki here as well: Developers.

Let us know whether you would like to keep the ticket open until your patches make it, or whether we can close it. Be aware that there are efforts underways to make things run on Python 3 already.

Updated by Bernhard Hailer 7 months ago

  • Status changed from Feedback to Closed
  • Target version set to chirp-daily

No more traffic on this ticket.

Also available in: Atom PDF

prevent spam