Feature #7615

[Yaesu FT-4, FT-65, FT-25] proposal for some reorg

Added by Bernhard Hailer 6 months ago. Updated 5 months ago.

Status:Closed Start date:01/27/2020
Priority:Normal Due date:
Assignee:Bernhard Hailer % Done:

100%

Category:-
Target version:chirp-daily
Chirp Version:daily Model affected:(All models)

Description

While implementing yet another radio of the Yaesu FT-4 family (the FT-4V, see #7387), I found that with some moderate reorganization, implementation of new radios will become even easier. The proposed reorganization will implement an intermediate layer of inheritance to support the sub families of FT-4 (containing the FT-4X and FT-4V) and FT-65 (containing FT-65 and FT-25). Also, some variable assignments would be moved from the individual radio classes to the SCU35 base class and to the intermediary classes named above. In my tests, this works well and improves maintainability.

I'm pretty much ready to submit a patch and will do so within the next couple of days.

Associated revisions

Revision 3298:d841aaba1977
Added by Bernhard Hailer 5 months ago

[ft4] driver restructure (#7615)

While implementing two more radios of the Yaesu FT-4 family (the FT-25, see #7543, and the FT-4V, see #7387), I found that with some moderate reorganization, implementation of new radios will become easier. The proposed reorganization implements one more interstitial layer of inheritance to support the sub families of FT-4 (containing the FT-4X and FT-4V) and FT-65 (containing FT-65 and FT-25). Also, some variable assignments have been moved from the individual radio classes to the SCU-35 base class and to the interstitial classes named above.

This change also adds the infrastructure for adding European or Asian models, and as such prepare for addressing a number of currently open issues (6.25kHz tune step issues on EU models, frequency limitations; see #6619, #6651, #6677, #6761, #6869). It will also make it easier for a few additional fixes for issues which were found during my work on this driver (#7601, #7603, #7605). I will submit these fixes in additional patches.

Fixes: #7615

Revision 3299:845362c4e800
Added by Dan Smith 5 months ago

Fix style issue in previous patch for #7615

History

Updated by Bernhard Hailer 6 months ago

  • Status changed from New to In Progress

Updated by Bernhard Hailer 6 months ago

  • Subject changed from [FT-4, FT-65, FT-25] proposal for some reorg to [Yaesu FT-4, FT-65, FT-25] proposal for some reorg

This change will also add the infrastructure for adding European or Asian models, and as such prepare to address a number of currently open issues (6.25kHz tune step issues on E models, frequency limitations).

Updated by Bernhard Hailer 5 months ago

  • Tracker changed from Bug to Feature
  • % Done changed from 90 to 100

Submitted. Once it goes through, I will submit patches for the remaining open FT-4/FT-65 issues and to add FT-25, FT-4V, and some EU version radios.

Updated by Anonymous 5 months ago

  • Status changed from In Progress to Closed

Applied in changeset d841aaba1977.

Also available in: Atom PDF