Project

General

Profile

Actions

Bug #9159

closed

Password stored in plain text in debug.log

Added by Joseph Pizzi almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
06/25/2021
Due date:
% Done:

100%

Estimated time:
Chirp Version:
daily
Model affected:
(All models)
Platform:
All
Debug Log:
I read the instructions above:

Description

I just attempted to download frequencies from RFinder. The attempt failed. In investigating, I discovered my password stored in plain text in the debug.log file.

Actions #1

Updated by Rudolph Gutzerhagen almost 3 years ago

Hey Joe,

do the log entries look like they were created by this code in rfinder.py ?

@def fetch_data(self, user, pw, coords, radius):
    """Fetches the data for a set of parameters"""
    LOG.debug(user)
    LOG.debug(pw)@
Actions #2

Updated by Joseph Pizzi almost 3 years ago

Most definitely. In fact (should have included this), the entries are:

[date/time] chirp.drivers.rfinder - DEBUG:
[date/time] chirp.drivers.rfinder - DEBUG:

Actions #3

Updated by Kosta A. almost 3 years ago

  • Status changed from New to Resolved
  • Assignee set to Kosta A.
  • % Done changed from 0 to 100
  • Platform changed from Windows to All

Commit pending to mail list to remove clear text logging of password.

Actions #4

Updated by Rudolph Gutzerhagen almost 3 years ago

in the mod I was preparing, I would have left some trace of information in the log:

@

  • LOG.debug("user id: {userid}".format(userid=user))
  • LOG.debug("password: a password of lenght {pwlen} was used"
  • .format(pwlen=len(pw)))@
Actions #5

Updated by Kosta A. almost 3 years ago

  • Status changed from Resolved to Closed

Applied in changeset commit:5e0cd9dc53b6.

Actions

Also available in: Atom PDF