Project

General

Profile

Actions

Feature #2355

closed

make codebase compliant with pep8

Added by Zach Welch over 9 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
02/24/2015
Due date:
% Done:

100%

Estimated time:
Chirp Version:
daily
Model affected:
(All models)
I read the instructions above:

Description

Since we want good Python style to be used, we should enforce it with the pep8 tool.

The first order of business will be to fix the whitespace problem. This single issue represents the vast majority of reported problems. Once this noise is eliminated, additional problems can be isolated and fixed. Per discussion with Dan S., we will move the code toward 4 space indentation levels (no tabs), proper spacing at top of scopes, line lengths < 80 characters, and so on. Some details will be worked out once patching is underway. Additional style conventions will be listed in this issue as this process moves forward.

The final goals of this issue are twofold. First, a firm style guide will be developed in the form of a specific configuration for the pep8 tool. Second, the pep8 tool will be added to the automated patch testing process, preventing further style issues from ever reaching the main repository.


Related issues 1 (0 open1 closed)

Related to Bug #2389: Cannot edit cells in all columnsClosed03/04/2015

Actions
Actions #1

Updated by Zach Welch over 9 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 60
Actions #2

Updated by Zach Welch over 9 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 60 to 100

This task has been accomplished. All of the CHIRP source code passes the pep8 tests, and the cpep8.py script is run as part of the run_all_tests.sh script.

The next step will be to make the source code compliant with pylint's stricter standards, but that is another feature entirely (#159).

Actions #3

Updated by Bernhard Hailer over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF