Project

General

Profile

Actions

Bug #8475

closed

Python3 Syntax errors

Added by Matthew Poletiek over 3 years ago. Updated over 1 year ago.

Status:
Rejected
Priority:
Normal
Category:
-
Target version:
Start date:
11/25/2020
Due date:
% Done:

0%

Estimated time:
Chirp Version:
daily
Model affected:
(All models)
Platform:
All
Debug Log:
I read the instructions above:

Description

Looks like the current py3 branch has 2 syntax errors. The first I discovered was in chirp/ui/mainapp.py on line 1140.

print query

needs to be

print(query)

Also, in chirp/drivers/vx6.py on line 874

except Exception, e:

needs to be

except (Exception, e):

After these changes were made py3 worked as I expected it to.


Files

py3syntax.patch (1.07 KB) py3syntax.patch Matthew Poletiek, 11/25/2020 10:34 AM
py3syntax.patch (1.07 KB) py3syntax.patch Matthew Poletiek, 12/14/2020 07:59 PM

Related issues

Related to Bug #8545: Python 3 Syntax Errors in Driver FilesClosedMatthew Poletiek12/10/2020

Actions
Actions #1

Updated by Matthew Poletiek over 3 years ago

Created the following patch to fix this.

Actions #2

Updated by Matthew Poletiek about 3 years ago

Better Patch

Actions #3

Updated by Matthew Poletiek about 3 years ago

Updated patch with better syntax.

@except (Exception, e):@ wasn't correct.

Correct answer is @except Exception as e:@

Actions #4

Updated by Bernhard Hailer about 3 years ago

Matthew, has your patch been posted to the developer's mailing list, has it been accepted? Thanks.

Actions #5

Updated by Matthew Poletiek about 3 years ago

Bernhard Hailer wrote:

Matthew, has your patch been posted to the developer's mailing list, has it been accepted? Thanks.

I haven't seen any movement on the py3 branch since February last year. I've made multiple posts to the dev list about this branch.

I've since forked this branch and have been working on my own repo here: https://github.com/mpoletiek/py3-CHIRP

Waiting until this February to make some irreversible changes to my own repo.

Actions #6

Updated by Dan Smith over 1 year ago

  • Status changed from New to Rejected

Patches for py3 should go to github.

Actions

Also available in: Atom PDF