Project

General

Profile

Actions

Bug #8545

closed

Python 3 Syntax Errors in Driver Files

Added by Matthew Poletiek over 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Start date:
12/10/2020
Due date:
% Done:

0%

Estimated time:
Chirp Version:
next (py3)
Model affected:
(All models)
Platform:
All
Debug Log:
I read the instructions above:

Description

Continuing to find syntax errors leftover from Python 2 in chirp/devices/

@
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/th9800: invalid syntax (th9800.py, line 601)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/th_uv3r: invalid syntax (wouxun.py, line 277)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/kguv8d: invalid syntax (kguv8d.py, line 379)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/th_uv3r25: invalid syntax (wouxun.py, line 277)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/vgc: invalid syntax (vgc.py, line 1413)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/retevis_rt21: invalid syntax (retevis_rt21.py, line 564)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/baofeng_uv3r: invalid syntax (baofeng_uv3r.py, line 54)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/mursv1: invalid syntax (baofeng_common.py, line 167)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/wouxun: invalid syntax (wouxun.py, line 277)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/baofeng_wp970i: invalid syntax (baofeng_common.py, line 167)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ft8100: Missing parentheses in call to 'print'. Did you mean print(self.VARIANT, number, tx_freq, mem.freq)? (ft8100.py, line 178)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ft50: invalid syntax (ft50.py, line 589)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/radioddity_r2: invalid syntax (radioddity_r2.py, line 614)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/kguv8e: invalid syntax (kguv8e.py, line 340)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ft60: invalid syntax (ft60.py, line 406)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ftm350: invalid syntax (ftm350.py, line 281)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/gmrsuv1: invalid syntax (baofeng_common.py, line 167)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/fd268: invalid syntax (fd268.py, line 793)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/radtel_t18: invalid syntax (radtel_t18.py, line 481)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/lt725uv: invalid syntax (lt725uv.py, line 1396)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ft2900: invalid syntax (ft2900.py, line 540)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/alinco: invalid syntax (alinco.py, line 202)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/bj9900: invalid syntax (bj9900.py, line 181)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/anytone: invalid syntax (anytone.py, line 180)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/tdxone_tdq8a: invalid syntax (tdxone_tdq8a.py, line 304)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/anytone_ht: invalid syntax (anytone_ht.py, line 236)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/baofeng_common: invalid syntax (baofeng_common.py, line 167)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ft2800: invalid syntax (ft2800.py, line 204)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/rh5r_v2: Missing parentheses in call to 'print'. Did you mean print(MEM_FORMAT)? (rh5r_v2.py, line 170)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/retevis_rt1: invalid syntax (retevis_rt1.py, line 729)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/uv6r: invalid syntax (baofeng_common.py, line 167)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ts590: invalid syntax (ts590.py, line 1647)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/th9000: invalid syntax (th9000.py, line 355)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ft450d: invalid syntax (ft450d.py, line 502)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/vxa700: invalid syntax (vxa700.py, line 180)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/leixen: invalid syntax (leixen.py, line 264)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/tk760g: invalid syntax (tk760g.py, line 910)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/uv5x3: invalid syntax (baofeng_common.py, line 167)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ap510: invalid syntax (ap510.py, line 383)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ts2000: Missing parentheses in call to 'print'. Did you mean print("Bug: unsupported duplex `%s'" % mem.duplex)? (ts2000.py, line 220)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/th_uv8000: invalid syntax (th_uv8000.py, line 1489)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ft7100: invalid syntax (ft7100.py, line 571)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/bf-t1: invalid syntax (bf-t1.py, line 228)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/bjuv55: invalid syntax (bjuv55.py, line 650)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ts480: invalid syntax (ts480.py, line 1141)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/kyd: invalid syntax (kyd.py, line 503)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/kyd_IP620: invalid syntax (kyd_IP620.py, line 184)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/rfinder: invalid syntax (rfinder.py, line 243)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/kguv8dplus: invalid syntax (kguv8dplus.py, line 421)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ftm3200d: invalid syntax (ft1d.py, line 1893)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ft90: invalid syntax (ft90.py, line 335)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/retevis_rt23: invalid syntax (retevis_rt23.py, line 849)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/puxing: invalid syntax (puxing.py, line 50)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/th7800: invalid syntax (th7800.py, line 539)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/kguv9dplus: invalid syntax (kguv9dplus.py, line 880)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ft2d: invalid syntax (ft1d.py, line 1893)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/retevis_rt22: invalid syntax (retevis_rt22.py, line 608)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/thd72: invalid syntax (thd72.py, line 584)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/thuv1f: invalid syntax (thuv1f.py, line 217)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/ft1d: invalid syntax (ft1d.py, line 1893)
Failed to import /Users/nicolas/Documents/py3CHIRP/chirp/drivers/retevis_rt26: invalid syntax (retevis_rt26.py, line 900)

@


Files

driver_syntax.patch (46.9 KB) driver_syntax.patch Matthew Poletiek, 12/10/2020 08:39 PM
driver_syntax.patch (46.9 KB) driver_syntax.patch Matthew Poletiek, 12/14/2020 08:42 PM

Related issues

Related to Bug #8475: Python3 Syntax errorsRejectedMatthew Poletiek11/25/2020

Actions
Actions #1

Updated by Matthew Poletiek over 3 years ago

Here's a patch.

Actions #2

Updated by Tony Fuller over 3 years ago

Helo, I just wanted to let you know that this patch is not correct. Python 2-> exceptions should be written as

except Exception as e

The current patch will try to catch either Exception or e, but e will probably be undefined.

Reference:
https://pythonprogramming.net/converting-python2-to-python3-2to3/

Actions #3

Updated by Matthew Poletiek over 3 years ago

Thanks Tony!

I went ahead and fixed that, see attached!

Actions #4

Updated by Bernhard Hailer about 3 years ago

Hi Matthew, has this been posted to the developer's mailing list, and has the patch been accepted?

Actions #5

Updated by Dan Smith over 1 year ago

  • Status changed from New to Closed

All the driver syntax errors have been fixed for a few weeks now in the py3 branch.

Actions #6

Updated by Dan Smith over 1 year ago

  • Chirp Version changed from daily to next (py3)
Actions

Also available in: Atom PDF