CHIRP

[py3] Changes to bitwise and friends for py3 compatibility

Much of this came from 2to3, but all the unicode/str/bytes changes were
hand-done. Unit tests pass for bitwise.

#495

[py3] Changes to make test_chirp_common (and deps) work on py3

This is enough to be able to use pytest too, so convert to that.

#495

[py3] Make platform module and tests py3 compatible

#495

[py3] Make settings module compatible and add its tests

#495

[py3] Changes to make test_directory compatible

#495

[py3] Changes to make test_shiftdialog compatible

This marks the point at which all the tests/unit tests pass in py3

#495

[py3] chirp/detect and chirp/logger 2to3 conversion

#495

[py3] Fix another unicode issue in directory and prevent drivers from crashing us

If a driver raises during detection, we should not kill the whole process.

#495

[py3] Changes to ui so that we can actually start under py3/gi

This adds a chirp.ui.compat module where we can pile things needed to
handle python3 differently. Right now there are a bunch of things that just fail
for reasons I don't fully grasp yet. Those go under a py3safe() decorator,
which logs and then ignores them.

Also, there is an issue with the sensitive=True bit on the columns for empty
memories. Need to figure that out.

#495

[py3] 2to3 run_tests.py and re-enable importing it in the unittest adapter

Also add pyserial to requirements because this is the first time we have
hit that import.

#495

[py3] Re-re-do of the charDataElement in bitwise

So, I've been a little bit on unicode autopilot, just trying to get the
data types to match up. However, once getting into the work of making
the drivers work, we have a ton that do things like this:

memobj.name = 'foobar\xFF'

because the radio needs the \xFF terminating byte to know where the end
of the string is. We need to not encode/decode that even on py3 because
we won't end up with the right value in memory if we do (and we'll fail
to encode/decode some values).

So, this cheats our unicodeness to end up with single-byte characters and
the right things get into/out of memory for now. Ideally all drivers would
be converted to bytestrings for things like that, but, babysteps.

Yes, I know how unicode works in Python, and yes I know this is not how
it's supposed to work.

#495

[py3] Another obligatory float->int conversion for an index

#495

[py3] Fix generic_csv writing to file

We need to open the file non-binary so we can write strings to it.

#495

[py3] Fix writing config

#495

[py3] Graceful fail on set_url_hook for about dialog

#495

[py3] Fix up a bunch of gtk3 issues

- Removed the authors on the about box as neither the gtk2 compat or gtk3
APIs seem to work. No offense to the other contributors, we can add it
back when we figure it out.
- Fix the get_cell_renderers() missing stuff in memedit and miscwidgets
- Quiet some of the py3safe() warnings which are known and not critical

#495

[py3] Fix up miscwidget.make_choice() and clone dialog

#495

[py3] Make hexprint work in py3 and add a test

#495

[py3] Make the straight string encoders both work on sequences

#495

[py3] Add a str-compatible MemoryMap implementation

I really hate to do this, but the more I dig into making a driver actually
work, I think this needs to be the default. I retained the bytes-clean
version as a base, and we can/should make new drivers use it, as well as
convert drivers to use it in this process. Bitwise still uses it under the
covers, so this is really just a usability shim to buy us some more time.

#495

[py3] Make icf work with python3

Just importing our modified struct module lets me run chirpw in python3,
upload and download from an id800.

#495

Update from default branch

#495

[py3] chirp_common.py: Fix file saving

#495

[py3] uvb5.py: Adapt for new Serial

#495

[py3] memedit.py: Convert power to str

#495

[py3] Fix bitwise structDataElement indexing with float

#495

[py3] Make bitwise get_raw() methods take asbytes=bool

This will enable modern drivers to get bytes instead of string

#495

[py3] A bunch of fixes to drivers that already import/run under py3

With this, all driver tests pass on py3 and py2, but note that most
of the drivers are still not even importing.

#495

[py3] bitwise.py: Always return a bytes-compatible object when asbytes=True

This commit ensures that drivers that ask for bytes representations will always
get bytes or a bytes-compatible object, whether on Python 2 or 3.

python-future provides a mostly-complete implementation of bytes for Python 2.

#495

[py3] Include requirements.txt and tests in sdist build

This will help make it easier to build and run tests on py2

#495

[py3] Fix safe_import_drivers() for win32

The glob'ing doesn't work on win32, especially in the frozen build, so
just do the old thing if we are on win32.

#495

[py3] Make memmap use future bytes

#495

[py3] Add an icom clone simulator (for non-raw mode) and test

This tests regular icom radios for byte-clean cloning and includes the
necessry changes to icf.py to make it work.

Tested on an ID800 and ID880

This doesn't address the live-mode radios, which still function under py2
properly. I don't have an IC-2730 to test with, but wrote unit tests for
the frame encoding routines, so hopefully that works as well.

#495

[py3] Fix memedit context menu to be gtk2/3 compatible

#495

[py3] Fix initializing memory range SpinButton on gtk3

#495

[py3] Fix making empty memories not sensitive on gtk3

We can do this in the render function (probably always should have), which
works on both.

#495

[py3] Minor 2to3 and struct wrapper conversion for uv5r driver

This makes the uv5r driver clone operations work under py3, but with the
compatibility layers in place.

#495

[py3] Fix editing empty memories on gtk3

In order to go from empty/sensitive=False to editing in gtk3 we have to do a little
more work.

#495

[py3] Fix icom cloning when a MemoryMap (not bytes) was handed to us

#495

[py3] Make kenwood_live radios use native serial

All the kenwood_live drivers speak ASCII to the radio using the exact same
low-level routine. They don't do any binary mapping or manipulation. Thus,
we really only need to do the usual unicode handling, and in one place. With
this change, all kenwood live radios should be good and not need independent
testing. Verified with a real TM-D700.

#495

[py3] Straight 2to3, plus StringStruct conversion of h777 and friends

Tested with a real Arcshell AR-6 (BF-888S)

#495

[py3] Fix integer divison in from_NHz() helpers

NOTE: These appear to be unused, except for one use of from_GHz() in the
icq7 driver. AFAICT, these have always been wrong in the tree, so this
just converts the division and adds (wrong) tests to validate the division
change, but they should be fixed (along with the icq7 driver).

#495

[py3] 2to3 of btech.py

Not tested with real hardware

#495

[py3] Make the clone test on py3 check that serial.write() passes proper data type

If a radio claims NEEDS_COMPAT_SERIAL=False, make sure it is writing with bytes and
not a string (and vice versa). This is not perfect because these are just clone
error tests, and all of the clone routine for a driver isn't going to get hit here.
But, it's something.

#495

[py3] Fix test_icom_clone finding the icom images

When I moved this into tests/unit I didn't realize it was not able to find the
images directory, and thus not doing anything. Make it smarter to be based
on the location of the test file itself.

#495

[py3] Fix up style issues introduced by 2to3 in ft8x7

#495

[py3] 2to3 of the ic208 driver

Not tested with real hardware

#495

[py3] Fix a couple style issues introduced in recent ic208 patch

#495

[py3] Make YaesuChecksum operate on bytes

#495

[py3] Make ft817 byte-clean

Tested with a real FT-817, expect ft857 and ft897 to be okay since they share so much.

#495

[py3] Convert ft7800 to byte-clean

Tested with a real FT7800

#495

[py3] Fix up python3 related failures found by the new delete memory test

#495

[py3] 2to3 conversion of vx2

Not tested with a real radio, but it passes tests and uses the yaesu_clone module
for cloning, so it is likely okay.

#495

[py3] Fix generic_tpe import of UserDict for python3

Untested as we have no sample files, but since this depends almost entirely
on the generic_csv driver (which works), it should be okay.

#495

[py3] Convert tk8102 driver to byte-clean

Tested with a real TK-8102

#495

Fix Edges::do_oddsteps() test

This test was completely wrong, and not really running for any driver. Realized it was
doing something stupid while trying to run it against the CSV driver (which supports
DC->daylight).

Some radios were claiming to support steps they don't support because they were taking
the full list in chirp_common as a default, which is clearly wrong. This patch changes
the default to a very conservative set, which may cause some drivers to no longer accept
some frequencies that may be valid because they were not declaring their real supported
list.

This also uncovered at least one buggy driver that can't support anything other than
5kHz step frequencies (ic2730).

Found in the pursuit of #495

[py3] Fix ict7h driver regression from 2to3 conversion

This fixes the ict7h driver for 12.5kHz step frequencies, uncovered by the
recent fix to the oddsteps test.

#495

[py3] Minor 2to3 change for kenwood_itm driver

No image in tree, so untested.

#495

Fix up the miscwidgets.make_choice() for non-editable combo boxes on gtk3

This was never finished before, and required a little more monkeywork to get
things working. This also fixes up the RepeaterBook prompting to work with
the new mechanism.

#495

[py3] Fix headless logger init on python3 because of file() usage

#495

Fix load_mmap() to provide the right memmap class based on the compat flag

#495

[py3] Log an error on memory load failure

...but do not choke.

#495

Set row label to mem.number to account for zero-origin radios

Related to #495

[py3] Fix memory properties editor

#495

[py3] Set column editor instead of per-cell

Massive improvement in grid setup time.

#495

Add a decorator/contextmanager that wraps a dangerous operation with an error message

#495

Center the MemoryDialog and do not reload the browser once loaded.

#495

Allow limiting driver loading for speed during development

This lets you only load the driver you are working on when running from
the command line, which speeds up startup quite a bit (especially if
working on a network share).

#495

[py3] More wrestling with the memory properties dialog and non-string choices

#495

[py3] Fix use of deprecated Menu::AppendItem to avoid warnings

#495

[py3] Fix second+ editors from being shown when selected on macos

For some reason intercepting the EDITOR_CHANGED event was causing the default
behavior of showing the editor pane to not happen on macos (only). Using the
EDITOR_CHANGING for our selected() purposes instead works around it.

#495

[py3] Make the memory editor use fixed-width fonts, like it should

#495

[py3] Make the radio browser pop open the first level by default

#495

[py3] Center the clone upload/download boxes by default

These don't center by default on macos for some reason, but do elsewhere.

#495

[py3] Re-select the last editor when reloading the radio.

#495